Skip to content

InterpHooks are incompatible between FillPatcher class and FillPatch function #2989

@BenWibking

Description

@BenWibking

The FillPatcher class requires PreInterpHook and PostInterpHook to have the signature:
void InterpHook(amrex::MultiFab &mf, int scomp, int ncomp);

whereas the FillPatch function requires the interpolation hooks to have the signature:
void InterpHook(amrex::FArrayBox &fab, const amrex::Box& box, int scomp, int ncomp);

This means that different interp hooks have to be used for each way of doing the fillpatch, which doesn't really make sense. The MultiFab version should be more efficient, since we can use the MultiFab ParallelFor, so it would be ideal if we can change the signature used in AMReX_FillPatchUtil_I.H:548 and similar.

Problem appears here: quokka-astro/quokka#133

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions