-
-
Notifications
You must be signed in to change notification settings - Fork 9
maximize back compat #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maximize back compat #354
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,75 +6,46 @@ on: | |
- "!dependabot/**" | ||
pull_request: | ||
workflow_dispatch: | ||
|
||
jobs: | ||
jest: | ||
name: Jest (Node v${{ matrix.node }}) | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
node: [14, 16, 17] | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Load Node version ${{ matrix.node }} | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
cache: npm | ||
- name: Npm Install | ||
run: npm ci | ||
- name: Run Jest | ||
run: npm run test:ci | ||
- name: Run Coveralls | ||
uses: coverallsapp/[email protected] | ||
if: matrix.node == '16' | ||
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
path-to-lcov: ./reports/lcov.info | ||
tests: | ||
uses: ljharb/actions/.github/workflows/node.yml@main | ||
with: | ||
range: '>= 0.8' | ||
type: majors | ||
build-command: npm run build:tests | ||
build-output-dir: __tests-built__,lib | ||
command: npm run tests-built | ||
|
||
flow: | ||
name: Flow type checking | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Load Node | ||
uses: actions/setup-node@v3 | ||
- uses: actions/checkout@v4 | ||
- uses: ljharb/actions/node/install@main | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does this do that's different from the standard There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It supports a wider range of node versions, and handles a lot of edge cases for npm installing in older ones. It also uses nvm to install node, and There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Easy way to sneak a backdoor in lol |
||
with: | ||
cache: npm | ||
- name: Npm Install | ||
run: npm ci | ||
use-npm-ci: true | ||
- name: Flow type check | ||
run: npm run flow | ||
|
||
eslint: | ||
name: ESLint (Node v${{ matrix.node }}) | ||
name: ESLint | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node: [16] | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Load Node version ${{ matrix.node }} | ||
uses: actions/setup-node@v3 | ||
- uses: actions/checkout@v4 | ||
- uses: ljharb/actions/node/install@main | ||
with: | ||
node-version: ${{ matrix.node }} | ||
cache: npm | ||
- name: Npm Install | ||
run: npm ci | ||
use-npm-ci: true | ||
- name: Run ESLint | ||
run: npm run lint | ||
|
||
diff-breakUpAriaJSON: | ||
name: Compare JSON to src output | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Load Node version | ||
uses: actions/setup-node@v3 | ||
- uses: actions/checkout@v4 | ||
- uses: ljharb/actions/node/install@main | ||
with: | ||
cache: npm | ||
- name: Npm Install | ||
run: npm ci | ||
use-npm-ci: true | ||
- name: Run diff check for the breakUpAriaJSON script | ||
run: node scripts/buildModelModules.js && git diff --exit-code -- src |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,6 @@ node_modules/ | |
lib/ | ||
reports/ | ||
docs/ | ||
.nyc_output/ | ||
coverage/ | ||
__tests-built__/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"all": true, | ||
"check-coverage": false, | ||
"reporter": ["text-summary", "text", "html", "json"], | ||
"lines": 86, | ||
"statements": 85.93, | ||
"functions": 82.43, | ||
"branches": 76.06, | ||
"exclude": [ | ||
"coverage", | ||
"test" | ||
] | ||
} |
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.