Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, some methods were implemented only in
Arroweven though they aremore general and applicable to all
Line-based objects (includingStrokeArrow).This caused:
Arrow).StrokeArrow).set_path_arcinLinedid not behave correctly).This PR moves/refactors these methods into the
Lineclass so that they can bereused consistently across all inheriting classes.
Proposed changes
reset_points_around_endsfromArrow→Line.set_path_arcinLineso that it works for bothArrowandStrokeArrow.set_perpendicular_to_camerafromArrow→Line.Arrow.Code
Result:
Line,Arrow, andStrokeArrow) correctly reset around their ends.set_path_arcnow applies consistently to bothArrowandStrokeArrow.set_perpendicular_to_cameraworks for all classes without duplication.