Skip to content

fix: Cannot copy applications with opening statement characters exceeding 4096 #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: Cannot copy applications with opening statement characters exceeding 4096 #3022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/application/serializers/application_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class ApplicationWorkflowSerializer(serializers.Serializer):
max_length=256, min_length=1,
error_messages=ErrMessage.char(_("Application Description")))
work_flow = serializers.DictField(required=False, error_messages=ErrMessage.dict(_("Workflow Objects")))
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=4096,
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=102400,
error_messages=ErrMessage.char(_("Opening remarks")))

@staticmethod
Expand Down Expand Up @@ -227,7 +227,7 @@ class ApplicationSerializer(serializers.Serializer):
min_value=0,
max_value=1024,
error_messages=ErrMessage.integer(_("Historical chat records")))
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=4096,
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=102400,
error_messages=ErrMessage.char(_("Opening remarks")))
dataset_id_list = serializers.ListSerializer(required=False, child=serializers.UUIDField(required=True),
allow_null=True,
Expand Down Expand Up @@ -495,7 +495,7 @@ class Edit(serializers.Serializer):
min_value=0,
max_value=1024,
error_messages=ErrMessage.integer(_("Historical chat records")))
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=4096,
prologue = serializers.CharField(required=False, allow_null=True, allow_blank=True, max_length=102400,
error_messages=ErrMessage.char(_("Opening remarks")))
dataset_id_list = serializers.ListSerializer(required=False, child=serializers.UUIDField(required=True),
error_messages=ErrMessage.list(_("Related Knowledge Base"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of issues in this code snippet:

  1. The allow_blank=True parameter is typically used with fields that accept Unicode strings (like text areas) instead of character strings (like single-line text). So the appropriate field type should be something like CharField, not Serializers.CharField. You can remove the allow_blank=True if you intended to use something else.

Here's an optimized version assuming UTF-8 encoding:

class Edit(serializers.Serializer):
    historical_chat_count = serializers.IntegerField(
                                required=False,
                                default=0,
                                min_value=0,
                                max_value=1024,
                                error_messages=dict(min_value=_('Minimum value: 0'),
                                                  max_value=_('Maximum value: 1024'))
                            )
    prologue = serializers Charfield(
                      required=False,
                      blank=True,
                      max_length=102400,   # Assuming maximum length of utf-8 characters
                      error_messages=dict(required=_('Prologue is required'))
                  )
    dataset_id_list = serializers.ListSerializer(
                         required=False,
                         child=serializers.UUIDField(),
                         allow_null=True,
                         error_messages=dict(max_length=_('Dataset ID list cannot be longer than allowed'))
                     )

Additionally, ensure all other fields follow the same logic as well, using the correct fields from Django REST Framework and adhering to best naming conventions for variables and attributes within classes.

Expand Down