Skip to content

Conversation

@burhandodhy
Copy link
Contributor

Description of the Change

This PR adds the text domain file so the plugin can be translatable.

Closes #

How to test the Change

Changelog Entry

Added - Make strings translatable

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy self-assigned this Mar 23, 2023
@burhandodhy burhandodhy added this to the 3.0.0 milestone Mar 23, 2023
@felipeelia
Copy link
Member

@burhandodhy this is a great idea, thanks for getting it started! We'll need some additional changes to have it properly done.

  1. Add Text Domain: my-plugin and Domain Path: /lang to the plugin header
  2. FWIW the load_plugin_textdomain isn't really needed if people are using WP.org translations but I think it doesn't hurt to keep it. That brought to my attention that we should add Requires at least: to the plugin header as well (it should match EP's). Do you mind taking care of that?
  3. As you are changing the release section, do you mind adding this line to it as well?

Here are the WP docs related to that.

Thanks!

@felipeelia felipeelia merged commit 0afb766 into develop Mar 23, 2023
@felipeelia felipeelia deleted the chore/register-text-domain branch March 23, 2023 12:43
felipeelia added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants