Fix: custom build dir path #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
requested review from
a team and
peterwilsoncc
and removed request for
a team
peterwilsoncc
approved these changes
Mar 17, 2022
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Using %/ makes sense, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that
rsyncneeds a full directory path with a trailing slash to copy nested files and directories. Without trailing slash,rsyncwill copy the directory itself.This PR fix that issue by forcing the
BUILD_DIRvariable to not has the trailing slash, then add a trailing slash to it when it's used forrsync.How to test this PR
See https://github.com/dinhtungdu/command-palette/runs/5584834600. I had to add the slash to the
BUILD_DIRin the workflow file to make the action deploy changes from the custom build directory.https://github.com/dinhtungdu/command-palette/blob/ca3f6d972e299007f7c1a0ab4c4e1befb222e00d/.github/workflows/deploy.yml#L16-L24