Set mime-type for SVG assets #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, can this be merged? |
dinhtungdu
previously approved these changes
Jan 7, 2022
iamdharmesh
previously approved these changes
Jan 7, 2022
|
Thanks! |
Member
|
@andrewheberle mind resolving the merge conflicts so this can get merged in? |
Member
|
@dinhtungdu @iamdharmesh can one of you look to resolve the conflicts and then merge this in? |
andrewheberle
dismissed stale reviews from iamdharmesh and dinhtungdu
via
78f6d43
Contributor
Author
|
@jeffpaul sorry for the long delay here. Conflicts are resolved. |
dinhtungdu
approved these changes
Jan 18, 2022
Contributor
dinhtungdu
left a comment
dinhtungdu
left a comment
There was a problem hiding this comment.
@andrewheberle Thanks for the PR and update! LGTM!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change sets files with a SVG extension in the
assets/directory toimage/svg+xmlso SVG format plugin icons are rendered correctly.Benefits
Ensures SVG images have the correct mime type.
Possible Drawbacks
Unknown
Verification Process
This is based on running the same manual command as has been added to
deploy.shChecklist:
Applicable Issues
10up/action-wordpress-plugin-asset-update#31
Changelog Entry
Added setting of SVG format assets to image/svg+xml