Skip to content

Conversation

@helen
Copy link
Collaborator

@helen helen commented Aug 16, 2021

Description of the Change

Failures with building the environment due to something going on with Debian (stable-slim), always felt that it was overly expensive for the actual needs of this action which is "just" a Bash script. The GitHub runners generally include all things necessary for this action - SVN, Git, rsync, and zip. Composite run steps are a thing as of about a year ago, and looks like as of the last couple months there is more official support for them being used as actions themselves. See https://docs.github.com/en/actions/creating-actions/creating-a-composite-run-steps-action

Alternate Designs

Switching from Debian to Ubuntu, but this still has issues around building the image, etc. We could cache it, but that is getting into wild overkill territory IMO.

Benefits

Faster runs with fewer dependencies

Possible Drawbacks

Not sure right now, need to test to see how exactly inputs and environment variables work with this method.

Verification Process

Will be testing on my test repo.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #73, fixes #60

Changelog Entry

Needs to be done

@helen helen marked this pull request as ready for review August 16, 2021 23:13
@helen helen changed the title [WIP] Convert into a composite action Convert into a composite action Aug 16, 2021
@helen
Copy link
Collaborator Author

helen commented Aug 16, 2021

Holy cow this is fast, and it fixes #60 to boot (had to, because I couldn't use the same path and I figured I might as well fully fix it while I was in here). This has been tested on a super secret live test repo I have.

@helen helen merged commit 72fb70b into develop Aug 16, 2021
@helen helen deleted the try/use-runner branch August 16, 2021 23:17
@helen helen added this to the 2.0.0 milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failing with docker error. Add output parameters for plugin ZIP path and name

1 participant