Skip to content

Assets svn propset commands fail #98

@lucyllewy

Description

@lucyllewy

Describe the bug

The glob of *.png, *.jpg, *.gif, and *.svg in the svn propset svn:mime-type commands fail due to being quoted. SVN does not support expanding the globs itself, so we need to rely on the shell expanding them. Shell globs are only expanded when the * is unquoted, but currently the whole path including the glob is within quotes meaning that we're trying to pass the literal string *.png etc with the * unexpanded.

Steps to Reproduce

  1. Ensure you have image assets in .wordpress.org directory in your plugin repo
  2. Run the action
  3. Check the logs
  4. Scroll down to '➤ Copying tag...'
  5. See error:
➤ Copying tag...
A         tags/4.3.0
'assets/*.png' is not under version control
svn: E155010: The node '/home/runner/svn-a-z-listing/assets/*.png' was not found.
'assets/*.jpg' is not under version control
svn: E155010: The node '/home/runner/svn-a-z-listing/assets/*.jpg' was not found.
'assets/*.svg' is not under version control
svn: E155010: The node '/home/runner/svn-a-z-listing/assets/*.svg' was not found.

Expected behavior

svn propset commands succeed

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions