Enable contract signers #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verride _defaultIsValidSignature with '_isAuthorized'
…litting existing ERC721AccountRails::isAuthorized() into isAuthorizedSigner and isAuthorizedForOperation
…hin validateUserOp()
… and _isValidContractSignature for better code reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for smart contract signers in both
isValidSignature()andvalidateUserOp()for all contracts inheriting from AccountRailsImproved readability and gas optimization by converting
isValidSignature()parameter to calldata, which allows for slicing rather than memory operations in assembly. This is not strictly outlined by the spec which defines the signature parameter in memory but more modern implementations use calldata for better efficiency and no tradeoff in usability since the function isn't called internally.Also added test cases to show smart contract signers. Will add one last commit to handle the offset introduced by the validator flag and then should be good to merge after review