Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite
writeLeb128to no longer usewriteMultipleOf7Leb128,instead:
writeableSliceGreedyinstead of an arrayRewrite
Reader.takeLeb128to not usetakeMultipleOf7Leb128andinstead:
For writing across larger integers (> 7 bits) this roughly doubles performance in a micro-benchmark.
For reading across larger integers (> 7 bits) this roughly doubles performance in a micro-benchmark, however with some notable exceptions:
i50sees barely any speedup andu50even sees a minor slowdown. Ihave genuinely no clue what could be causing this, it's the exception
to the rule.