Release 1.0 #992
Open
Release 1.0 #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clarify behavior of Z for octahedral encoding (encoder writes 1.f, decoder expects it) - Clarify data addressing for meshlets (for triangle data, range is offset..offset+count*3) - Fix inconsistent parameter name for meshopt_analyzeVertexCache templated overload - meshopt_quantizeFloat preserves infinities (overflows are impossible) - Minor grammar/wording fixes
Without this, access to CJS compatibility version of meshopt decoder is not allowed by node, and potentially other bundlers. While we could reuse "./decoder" export for this, it seems cleaner to separate it so that the caller intentionally uses the CJS variant. Node implicitly supports require on ESM files anyway so it is better that the exports without a suffix route to the ESM files consistently - especially because the resulting interface is a little different.
- Link to clusterlod.h from the initial section to make it easier to discover. - Note that for multi-subset simplification a simple concatenation is sufficient. - Fix normal quantization example that was encoding normal components using 0..1 range. - Fix wording in a few places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIs that are still experimental in this release:
meshopt_SimplifyPermissiveflag formeshopt_simplify*functions (and associatedmeshopt_SimplifyVertex_*flags)Closes #940.