Skip to content

Conversation

@strickvl
Copy link
Contributor

Summary

This PR applies fixes learned from testing AI agent GitHub Actions in zenml-io/gh-action-testing:

  • Claude workflows: Change trigger pattern from /claude to @claude

    • The Claude Code Action uses tag mode by default and requires @claude mentions
    • Without this fix, the action logs show "No trigger was met for @claude" and skips
  • Codex post-comment job: Fix multiline output handling issues

    • Use always() && needs.run-codex.result == 'success' for more reliable job evaluation
    • Move empty message check to step level
    • Use template literals instead of env vars for multiline content
    • Use explicit ${{ github.event.issue.number }} instead of context.issue.number
    • Add debug step for troubleshooting

Test plan

  • Trigger Claude with @claude Say hello! on a PR
  • Trigger Claude full review with @claude /full-review on a PR
  • Trigger Codex with /codex Say hello! on a PR
  • Verify post-comment job posts the response correctly

- Change Claude workflows from /claude to @claude triggers
  (required by anthropics/claude-code-action internal trigger detection)
- Fix Codex post-comment job to handle multiline outputs properly:
  - Use always() in job condition to avoid expression evaluation issues
  - Move empty message check to step level
  - Use template literals instead of env vars for multiline content
  - Use explicit github.event.issue.number reference
  - Add debug step for troubleshooting

These fixes were validated in zenml-io/gh-action-testing before applying here.
@strickvl strickvl changed the title ci: fix Claude trigger pattern and Codex post-comment job Fix Claude trigger pattern and Codex post-comment job Nov 28, 2025
@strickvl strickvl added bug Something isn't working snack labels Nov 28, 2025
@strickvl strickvl removed this from ZenML Roadmap Nov 28, 2025
@strickvl strickvl moved this to In Review in ZenML Roadmap Nov 28, 2025
@Cahllagerfeld Cahllagerfeld merged commit 6bab4cc into main Nov 28, 2025
3 checks passed
@Cahllagerfeld Cahllagerfeld deleted the bug/claude-ci-bot-fixes-final-ones branch November 28, 2025 15:27
@htahir1 htahir1 moved this from In Review to Merged in ZenML Roadmap Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working snack

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants