Skip to content

import operator has been supported #29375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

import operator has been supported #29375

wants to merge 3 commits into from

Conversation

@dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Nov 23, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings November 23, 2025 00:03
@dorooleg dorooleg requested a review from a team as a code owner November 23, 2025 00:03
Copilot finished reviewing on behalf of dorooleg November 23, 2025 00:06
Copilot AI reviewed Nov 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for import/restore operations in the columnshard transaction system. The change introduces a new transaction type TX_KIND_RESTORE and implements the corresponding operator, task, session, and actor infrastructure to handle restore operations, mirroring the existing export functionality.

  • Adds TRestoreTransactionOperator to handle restore transactions
  • Implements import task, session, and actor components in the backup/import directory
  • Registers the new TX_KIND_RESTORE transaction kind in the proto definitions

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ydb/core/tx/columnshard/transactions/operators/ya.make Adds restore.cpp to the build configuration
ydb/core/tx/columnshard/transactions/operators/restore.h Declares TRestoreTransactionOperator class for handling restore transactions
ydb/core/tx/columnshard/transactions/operators/restore.cpp Implements restore transaction operator with lifecycle methods
ydb/core/tx/columnshard/backup/ya.make Adds import subdirectory as a dependency
ydb/core/tx/columnshard/backup/import/ya.make Defines the import library build configuration
ydb/core/tx/columnshard/backup/import/task.h Declares TImportTask class for managing import operations
ydb/core/tx/columnshard/backup/import/task.cpp Implements import task serialization and session building
ydb/core/tx/columnshard/backup/import/session.h Declares TSession class representing an import session state machine
ydb/core/tx/columnshard/backup/import/session.cpp Implements import session lifecycle and state transitions
ydb/core/tx/columnshard/backup/import/protos/ya.make Adds protobuf definitions for import tasks
ydb/core/tx/columnshard/backup/import/protos/task.proto Defines protobuf messages for import task serialization
ydb/core/tx/columnshard/backup/import/import_actor.h Declares TImportActor for executing import operations
ydb/core/tx/columnshard/backup/import/import_actor.cpp Implements import actor behavior and transaction handling
ydb/core/tx/columnshard/backup/import/control.h Declares session control classes for confirming/aborting imports
ydb/core/tx/columnshard/backup/import/control.cpp Implements session control logic
ydb/core/protos/tx_columnshard.proto Adds TX_KIND_RESTORE enum value and TRestoreTxBody message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 23, 2025

🟢 2025-11-23 00:09:39 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 00:12:23 UTC Pre-commit check linux-x86_64-release-asan for f0211ff has started.
⚪ 2025-11-23 00:12:42 UTC Artifacts will be uploaded here
⚪ 2025-11-23 00:14:56 UTC ya make is running...
🔴 2025-11-23 01:07:53 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 00:15:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0211ff has started.
⚪ 2025-11-23 00:15:11 UTC Artifacts will be uploaded here
⚪ 2025-11-23 00:17:02 UTC ya make is running...
🔴 2025-11-23 01:11:33 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 08:53:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6299478 has started.
⚪ 2025-11-23 08:53:32 UTC Artifacts will be uploaded here
⚪ 2025-11-23 08:55:46 UTC ya make is running...
🔴 2025-11-23 09:28:56 UTC Build failed, see the logs. Also see fail summary
🟡 2025-11-23 09:29:20 UTC ydbd size 2.3 GiB changed* by +797.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b8bc549 merge: 6299478 diff diff %
ydbd size 2 454 696 848 Bytes 2 455 513 680 Bytes +797.7 KiB +0.033%
ydbd stripped size 523 129 528 Bytes 523 193 048 Bytes +62.0 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 08:54:05 UTC Pre-commit check linux-x86_64-release-asan for 6299478 has started.
⚪ 2025-11-23 08:54:22 UTC Artifacts will be uploaded here
⚪ 2025-11-23 08:56:35 UTC ya make is running...
🔴 2025-11-23 09:27:54 UTC Build failed, see the logs. Also see fail summary
🟡 2025-11-23 09:28:30 UTC ydbd size 3.8 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b8bc549 merge: 6299478 diff diff %
ydbd size 4 109 044 040 Bytes 4 110 193 528 Bytes +1.1 MiB +0.028%
ydbd stripped size 1 527 256 432 Bytes 1 527 489 136 Bytes +227.2 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 23:12:05 UTC Pre-commit check linux-x86_64-release-asan for 8f3d27e has started.
⚪ 2025-11-23 23:12:21 UTC Artifacts will be uploaded here
⚪ 2025-11-23 23:14:28 UTC ya make is running...
🔴 2025-11-24 00:21:22 UTC Too many tests failed, NOT going to retry
🟡 2025-11-24 00:24:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6804 2526 0 4062 2 214

🟢 2025-11-24 00:24:28 UTC Build successful.
🟡 2025-11-24 00:25:07 UTC ydbd size 3.8 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d14cebe merge: 8f3d27e diff diff %
ydbd size 4 109 494 336 Bytes 4 110 640 016 Bytes +1.1 MiB +0.028%
ydbd stripped size 1 527 403 056 Bytes 1 527 631 952 Bytes +223.5 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 23, 2025 •
edited
Loading

⚪ 2025-11-23 23:17:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8f3d27e has started.
⚪ 2025-11-23 23:17:22 UTC Artifacts will be uploaded here
⚪ 2025-11-23 23:19:33 UTC ya make is running...
🔴 2025-11-24 00:35:23 UTC Too many tests failed, NOT going to retry
🔴 2025-11-24 00:42:36 UTC Some tests failed, follow the links below.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22567 9377 0 9808 2712 670

🟢 2025-11-24 00:42:48 UTC Build successful.
🟡 2025-11-24 00:43:19 UTC ydbd size 2.3 GiB changed* by +801.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d14cebe merge: 8f3d27e diff diff %
ydbd size 2 454 898 248 Bytes 2 455 719 168 Bytes +801.7 KiB +0.033%
ydbd stripped size 523 165 528 Bytes 523 233 144 Bytes +66.0 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dorooleg