Make flat_mem_iter.h usable with Standard Libraries that return itera…

[apolukhin]

…tors other than pointers

Changelog entry

...

Changelog category

• Not for changelog (changelog entry is not required)

Description for reviewers

...

[github-actions]

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

[github-actions]

🟢 2025-11-22 12:58:09 UTC The validation of the Pull Request description is successful.

[github-actions]

⚪ 2025-11-22 13:33:46 UTC Pre-commit check linux-x86_64-release-asan for 29036bd has started.
⚪ 2025-11-22 13:34:03 UTC Artifacts will be uploaded here
⚪ 2025-11-22 13:36:06 UTC ya make is running...
🟡 2025-11-22 15:12:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
13576	13494	0	65	9	8

🟢 2025-11-22 15:12:21 UTC Build successful.
🟢 2025-11-22 15:12:44 UTC ydbd size 3.8 GiB changed* by -800 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: 6a893e7	merge: 29036bd	diff	diff %
ydbd size	4 109 043 864 Bytes	4 109 043 064 Bytes	-800 Bytes	-0.000%
ydbd stripped size	1 527 256 560 Bytes	1 527 256 560 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2025-11-22 13:33:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 29036bd has started.
⚪ 2025-11-22 13:34:13 UTC Artifacts will be uploaded here
⚪ 2025-11-22 13:36:18 UTC ya make is running...
🟡 2025-11-22 15:43:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
40542	37671	0	2	2840	29

⚪ 2025-11-22 15:43:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-22 15:56:01 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
64 (only retried tests)	48	0	0	0	16

🟢 2025-11-22 15:56:07 UTC Build successful.
🟢 2025-11-22 15:56:26 UTC ydbd size 2.3 GiB changed* by +128 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: 6a893e7	merge: 29036bd	diff	diff %
ydbd size	2 454 697 008 Bytes	2 454 697 136 Bytes	+128 Bytes	+0.000%
ydbd stripped size	523 129 656 Bytes	523 129 656 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[Copilot]

Pull request overview

This PR improves compatibility with Standard Libraries that return iterator types (other than raw pointers) from .begin() by changing to use .data() instead when constructing TDbTupleRef objects in flat_mem_iter.h.

• Changed line 142 to use .data() instead of .begin() for accessing vector elements when constructing TDbTupleRef

Comments suppressed due to low confidence (1)

ydb/core/tablet_flat/flat_mem_iter.h:136

• Inconsistent use of .begin() for KeyCellDefaults->BasicTypes(). This should use .data() to match line 142 and ensure compatibility with Standard Libraries that return iterators other than pointers. The TDbTupleRef constructor expects a pointer (const TCell*), not an iterator.

                return { KeyCellDefaults->BasicTypes().begin(), key, len };

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[azevaykin]

Comments suppressed due to low confidence (1)
ydb/core/tablet_flat/flat_mem_iter.h:136

• Inconsistent use of .begin() for KeyCellDefaults->BasicTypes().

@apolukhin Please look at line 136. It's supposed to be changed to .data() also.

[github-actions]

⚪ 2025-11-24 10:06:19 UTC Pre-commit check linux-x86_64-release-asan for b940cf1 has started.
⚪ 2025-11-24 10:06:37 UTC Artifacts will be uploaded here
⚪ 2025-11-24 10:08:46 UTC ya make is running...
🟡 2025-11-24 11:59:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
13588	13464	0	88	21	15

🟢 2025-11-24 11:59:21 UTC Build successful.
🟢 2025-11-24 11:59:55 UTC ydbd size 3.8 GiB changed* by +78.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: 7e555f7	merge: b940cf1	diff	diff %
ydbd size	4 110 083 808 Bytes	4 110 163 688 Bytes	+78.0 KiB	+0.002%
ydbd stripped size	1 527 733 392 Bytes	1 527 755 920 Bytes	+22.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2025-11-24 10:08:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for b940cf1 has started.
⚪ 2025-11-24 10:08:29 UTC Artifacts will be uploaded here
⚪ 2025-11-24 10:10:39 UTC ya make is running...
🟡 2025-11-24 12:18:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
40554	37683	0	5	2837	29

⚪ 2025-11-24 12:18:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-24 12:31:35 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
63 (only retried tests)	45	0	0	0	18

🟢 2025-11-24 12:31:42 UTC Build successful.
🟢 2025-11-24 12:32:06 UTC ydbd size 2.3 GiB changed* by +128 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: fada896	merge: b940cf1	diff	diff %
ydbd size	2 455 294 328 Bytes	2 455 294 456 Bytes	+128 Bytes	+0.000%
ydbd stripped size	523 292 888 Bytes	523 292 888 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}