quicker result rows release to avoid potential overload #29362
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the result row flushing mechanism in the stream lookup worker to make results available earlier, potentially avoiding overload conditions. The key change is the introduction of a FlushedResultRows queue that eagerly stores completed result rows instead of keeping them in ResultRowsBySeqNo until ReplyResult() is called.
- Introduces
FlushedResultRowsdeque to store completed result rows - Adds
FlushRowsIfNeeded()method to eagerly move rows toFlushedResultRows - Refactors
ReplyResult()to consume fromFlushedResultRowsinstead of iterating throughResultRowsBySeqNo
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| while (!resultStats.SizeLimitExceeded) { | ||
| auto resultIt = getNextResult(); | ||
| if (resultIt == ResultRowsBySeqNo.end()) { | ||
| while(true) { |
There was a problem hiding this comment.
Missing space between while and (. The codebase consistently uses while ( with a space (see lines 32, 267, 335, 402, 720, 736, 943). This should be while (true) for consistency.
| while(true) { | |
| while (true) { |
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
gridnevvvit
force-pushed
the
quicker-release-result-rows
branch
from
190ac36 to
e3cc0bf
Compare
gridnevvvit
changed the title
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
gridnevvvit
force-pushed
the
quicker-release-result-rows
branch
from
e3cc0bf to
0a0ff04
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
BackportTo backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.
|
|
Backport results: |
3 participants
Changelog entry
...
Changelog category
Description for reviewers
...