Skip to content

refactor: simplify class binding in Node components #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
984507092 wants to merge 1 commit into from
Closed

refactor: simplify class binding in Node components #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/elements/src/node/Node.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ interface NodeProps {

const props = defineProps<NodeProps>()
const delegatedProps = reactiveOmit(props, 'class')

const nodeClass = computed(() => cn('node-container relative size-full h-auto w-sm gap-0 rounded-md p-0', props.class))
</script>

<template>
<Card
v-bind="delegatedProps"
:class="cn('node-container relative size-full h-auto w-sm gap-0 rounded-md p-0', props.class)"
:class="nodeClass"
>
<Handle v-if="props.handles?.target" :position="Position.Left" type="target" />
<Handle v-if="props.handles?.source" :position="Position.Right" type="source" />
Expand Down
3 changes: 2 additions & 1 deletion packages/elements/src/node/NodeFooter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ import { cn } from '@repo/shadcn-vue/lib/utils'
const props = defineProps<{
class?: HTMLAttributes['class']
}>()
const className = computed(() => cn('rounded-b-md border-t bg-secondary p-3!', props.class))
</script>

<template>
<CardFooter :class="cn('rounded-b-md border-t bg-secondary p-3!', props.class)">
<CardFooter :class="className">
<slot />
</CardFooter>
</template>
3 changes: 2 additions & 1 deletion packages/elements/src/node/NodeHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ import { cn } from '@repo/shadcn-vue/lib/utils'
const props = defineProps<{
class?: HTMLAttributes['class']
}>()
const className = computed(() => cn('gap-0.5 rounded-t-md border-b bg-secondary p-3!', props.class))
</script>

<template>
<CardHeader :class="cn('gap-0.5 rounded-t-md border-b bg-secondary p-3!', props.class)">
<CardHeader :class="className">
<slot />
</CardHeader>
</template>