Skip to content

Fix IndexOutOfBoundsException #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v24
Choose a base branch
from
Open

Fix IndexOutOfBoundsException #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tion-grid-flow/src/main/java/com/vaadin/componentfactory/selectiongrid/SelectionGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ private Set<T> obtainNewSelectedItems(int fromIndex, int toIndex) {
int from = Math.min(fromIndex, toIndex);
int to = Math.max(fromIndex, toIndex) + 1;
int pageSize = dataCommunicator.getPageSize();
if (to - from < (pageSize * 2) - 3) {
if (dataCommunicator.getItemCount() > 0 && to - from < (pageSize * 2) - 3) {
// if the range to be retrieved is smaller than 2 pages
// ask the dataCommunicator to retrieve the items so the cache is used
for(int i = from; i < to; i++) {
Expand Down