refactor and remove the local package check which looked for link, yalc or file:
#1208
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Only upload packages that are explicitly listed in dependencies | ||
| if (!isProjectDependency) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Lines 593-596 now skip every resolved dependency that is not listed in the root package.json. When using a locally linked/file:/yalc package, its own dependencies are discovered by collectAllNodeModuleDependencies but typically are not declared in the app’s dependencies, so this filter drops them and they are never uploaded. Any linked package that imports its own dependency (e.g., axios inside the linked library) will now hit MODULE_NOT_FOUND on the server because those files are omitted, whereas the previous hasLocalPackages path uploaded these transitive deps.
Useful? React with 👍 / 👎.
imrishabh18
changed the title
link, yalc or file:link, yalc or file:
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Have separated out the methods used in the
getAllNodeModuleFilePathsto make it more readableDevServer now uploads all the packages listed in the package.json
dependencies