-
Notifications
You must be signed in to change notification settings - Fork 13
add docker_image selection parameter #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 29 29
Lines 2085 2089 +4
=======================================
+ Hits 2049 2053 +4
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Perhaps just "image"? |
…with older versions
|
Is there actually a backwards compatibility problem on the server side? Could the relevant tests get added? |
…into 1162-support-custom-topcp-images
…into 1162-support-custom-topcp-images
|
@ponyisi I resolved the testing issues earlier this week. What backward compatibility issues are you thinking of? Testing locally, when I send a request to the latest My app pod has the following logged: And the codegen: |
|
@MattShirley - would it be useful to check whether the user-defined image exists before send it to backend? |
Adds
docker_imageto selection criteria. Front end work for ssl-hep/ServiceX#1162