-
-
Notifications
You must be signed in to change notification settings - Fork 559
fix(role): Add automatic SCRAM-SHA-256 password escaping and docs #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-703
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] SCRAM-SHA-256 documentation
Add automatic SCRAM-SHA-256 password escaping and comprehensive documentation
Sep 11, 2025
Copilot finished work on behalf of
damacus
September 11, 2025 23:18
bmhughes
reviewed
Sep 14, 2025
bmhughes
previously approved these changes
Sep 14, 2025
bmhughes
reviewed
Sep 14, 2025
bmhughes
reviewed
Sep 14, 2025
bmhughes
reviewed
Sep 14, 2025
bmhughes
reviewed
Sep 14, 2025
bmhughes
reviewed
Sep 14, 2025
bmhughes
reviewed
Sep 14, 2025
Copilot finished work on behalf of
bmhughes
September 14, 2025 17:40
Copilot finished work on behalf of
bmhughes
September 14, 2025 17:44
bmhughes
approved these changes
Sep 14, 2025
|
This is ready to release. But I'm going to move it over to the new release workflow before releasing. |
Slowest examplesTop 10 slowest examples (0.02 seconds, 53.28% of total time)
|
…entation Co-authored-by: damacus <[email protected]>
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: bmhughes <[email protected]>
Changed from excessive \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ (8 backslashes) to proper \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ (4 backslashes) for SQL escaping. Each backslash in the original password is now correctly escaped as \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ (2 backslashes) in the result. Co-authored-by: bmhughes <[email protected]>
Co-authored-by: bmhughes <[email protected]>
9e5ae73 to
d55d38e
Compare
Slowest examplesTop 10 slowest examples (0.01 seconds, 49.31% of total time)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Release: Patch
Release to Chef Supermarket as a version patch when merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses the SCRAM-SHA-256 password handling issue where
$characters in password hashes were being mangled during SQL execution, causing authentication failures.Key improvements:
SCRAM-SHA-256$characters are automatically escaped as\$to prevent shell interpretation\\\\\\\\to proper\\\\for SQL safetynil_or_empty?utility function for cleaner password validationSolution
Users can now simply write:
The cookbook automatically escapes the password for safe SQL execution.
Testing
Verified that:
$and\characters)Fixes #703.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.