Skip to content

Improve scalar UDFs performance #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve scalar UDFs performance #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions singlestoredb/functions/ext/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,15 +326,16 @@ async def do_func(
rows: Sequence[Sequence[Any]],
) -> Tuple[Sequence[int], List[Tuple[Any, ...]]]:
'''Call function on given rows of data.'''
out = []
tasks = []
async with timer('call_function'):
for row in rows:
cancel_on_event(cancel_event)
if is_async:
out.append(await func(*row))
tasks.append(func(*row))
else:
out.append(func(*row))
return row_ids, list(zip(out))
tasks.append(asyncio.to_thread(func, *row))

return row_ids, list(zip(await asyncio.gather(*tasks)))

return do_func

Expand Down