Skip to content

Conversation

@newkit
Copy link
Member

@newkit newkit commented Dec 1, 2025

kubernetes.core was missing in requirements.yml, added it now.

@newkit newkit requested a review from marcelmamula December 1, 2025 08:28
@marcelmamula
Copy link
Contributor

@newkit Any specific reason why you set version 6 months old? We will have to bump up other versions soon, or switch to dynamic >= to add some future proofing.

@dominikholler
Copy link

@0xFelix might the reason to limit to a lower version in kubevirt/kubevirt.core#192 be apply here, too?

requirements.yml Outdated
version: 1.5.0
- name: kubernetes.core
type: galaxy
version: 5.3.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using >=5.2.0,<7.0.0 as version constraint the collection is able to use any recent version of kubernetes.core, from the 5 series, as well as from the 6 series. Both series work mostly the same and should be compatible to each other.

Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula requested a review from 0xFelix December 16, 2025 10:53
@newkit newkit merged commit f98a69c into sap-linuxlab:dev Dec 16, 2025
17 checks passed
@newkit newkit deleted the add_kubernetes.core_requirement branch December 16, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants