Allow sending set of provider-specific CSV files #420 #430
Conversation
app/jobs/file_upload_job.rb
Outdated
| # Consider removing concurrency limits due to SolidQueue blocking issues | ||
| # or use a more specific key to avoid blocking all jobs for a language | ||
| limits_concurrency to: 3, key: ->(_language_id, content_id, _content_type) { "hard-limit" } | ||
| limits_concurrency to: 3, key: ->(_language_id, _content_id, _content_type) { "hard-limit" } |
There was a problem hiding this comment.
Wouldn't we keep the param names in parallel with the perform params? _language_id, _file_id, _provider_id?
To be clear, I don't fully grasp how the concurrency keys work.
There was a problem hiding this comment.
When I run locally I get this error.
There was a problem hiding this comment.
This param is unused. However, number of parameters here should match the number of parameters when we call the job. I am trying to replace this with just *args
There was a problem hiding this comment.
I'm pushing this branch to staging so Manoj can review the files.
dmitrytrager
force-pushed
the
provider-specific-csv-files-420
branch
from
a11f8e8 to
47a6a0b
Compare
|
Manoj said the file formats are working but he has some changes to the naming convention. He's going to get that to me later this week. |
Still waiting for that from Manoj. |
|
The answer was that they want to require the providers to have a file name prefix and use that as the prefix for these files. I have some concerns I'd like to discuss. |
2 participants
What Issue Does This PR Cover, If Any?
Resolves #420 The best issue number!
What Changed? And Why Did It Change?
FileUploadJobto receive language or providerHow Has This Been Tested?
Please Provide Screenshots
Additional Comments