-
Notifications
You must be signed in to change notification settings - Fork 47
DOC-1667 Document Shadow Link in Cloud #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis PR implements environment-specific documentation branching for disaster recovery shadowing features. It updates the Antora playbook to reference a feature branch for cloud-docs content, then modifies multiple shadowing documentation files to include conditional content blocks that differentiate between cloud and non-cloud environments. Environment-specific sections are gated using ifndef::env-cloud[] and ifdef::env-cloud[] directives, and single-source region markers delineate content boundaries. A new cloud-specific tip file is introduced, cross-reference links are corrected from deploy: to manage: module paths, and minor terminology and formatting adjustments are applied throughout. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
f533461 to
6b96f68
Compare
|
In Monitoring, Under metrics, it would be great to include the detail that the metrics are available via the /public_metrics endpoint |
|
In monitoring the Alert thresholds section should be renamed to Alert conditions |
|
On Monitoring - The Status command options: feels duplicative, it doesn't have anything different than the previous command. Could we remove it? |
treevon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the new structure. I have some minor edits.
| The starting offset only affects **new shadow topics**. After a shadow topic exists and has data, changing this setting has no effect on that topic's replication. | ||
| ==== | ||
|
|
||
| === Generate a sample configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this right under Set Up Shadowing? We should explain the configuration file before suggesting users create a shadow link using a configuration file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Reading this again with fresh eyes docs/modules/manage/pages/disaster-recovery/shadowing/overview.adoc Lines 213 to 221 in a68335b
|
|
|
||
| === Administrative access | ||
|
|
||
| Superuser access is required on both clusters through xref:get-started:rpk/index.adoc[`rpk`], the Admin API, or xref:console:index.adoc[Redpanda Console] to create and manage shadow links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the admin requirement for cloud? do we have superusers there too? @simon0191
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| **Avoid name conflicts:** If you plan to consume data from the shadow cluster, do not use the same consumer group names as those used on the source cluster. While this won't break shadow linking, it can impact your RPO/RTO because conflicting group names may interfere with offset replication and consumer resumption during disaster recovery. | ||
|
|
||
| **Offset clamping:** When Redpanda replicates consumer group offsets from the source cluster, offsets are automatically "clamped" during the commit process on the shadow cluster. If a committed offset from the source cluster is above the high watermark (HWM) of the corresponding shadow partition, Redpanda clamps the offset to the shadow partition's HWM before committing it to the shadow cluster. This ensures offsets remain valid and prevents consumers from seeking beyond available data on the shadow cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Offset clamping:** When Redpanda replicates consumer group offsets from the source cluster, offsets are automatically "clamped" during the commit process on the shadow cluster. If a committed offset from the source cluster is above the high watermark (HWM) of the corresponding shadow partition, Redpanda clamps the offset to the shadow partition's HWM before committing it to the shadow cluster. This ensures offsets remain valid and prevents consumers from seeking beyond available data on the shadow cluster. | |
| **Offset clamping:** When Redpanda replicates consumer group offsets from the source cluster, offsets are automatically "clamped" during the commit process on the shadow cluster. If a committed offset from the source cluster is above the HWM of the corresponding shadow partition, Redpanda clamps the offset to the shadow partition's HWM before committing it to the shadow cluster. This ensures offsets remain valid and prevents consumers from seeking beyond available data on the shadow cluster. |
with glossary maybe we can say HWM for high water mark
|
|
||
| * **Shadow link state**: Overall operational state (`ACTIVE`) | ||
| * **Individual topic states**: Current state of each replicated topic (`ACTIVE`, `FAULTED`, `FAILING_OVER`, `FAILED_OVER`) | ||
| * **Shadow link state**: Overall operational state (`ACTIVE`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one can be ACTIVE or PAUSED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simon0191 I updated on Monitor page and also on Failover page. Please confirm that the description for PAUSED is correct.
| The architecture follows an active-passive pattern. The source cluster processes all production traffic while the shadow cluster remains in read-only mode, continuously receiving updates. If a disaster occurs, you can failover the shadow topics using the | ||
| ifndef::env-cloud[Admin API] | ||
| ifdef::env-cloud[Data Plane API] | ||
| or `rpk`, making them fully writable. At that point, you can redirect your applications to the shadow cluster, which becomes the new production cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should warn the user about the potential for creating a split brain scenario if they don't ensure that all their clients are reconfigured to point to the shadow cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Paulo Borges <[email protected]>
3118ad6 to
aea6e82
Compare
|
Merging this now. Kat will then create a new PR to add Cloud API info and any other updates necessary for Cloud with rpk & UI. Single sourcing for this in |
Description
This pull request single sources and conditionalizes Shadowing content for Cloud.
It also restructures the configuration page, moving conceptual content into the overview & moving Create shadow link section toward the top of the config page.
(Single sourcing for this in
cloud-docsrepo is done in redpanda-data/cloud-docs#462. That one will merge Dec 12, to make Shadowing visible in Cloud docs.)// tag::single-source[]and// end::single-source[]markers to support reuse and conditional rendering across cloud and self-hosted documentation. [1] [2] [3] [4] [5]ifdef::env-cloud[]andifndef::env-cloud[]blocks for environment-specific notes, requirements, and tips—such as licensing, authentication, and cluster property configuration. [1] [2] [3]Resolves https://redpandadata.atlassian.net/browse/DOC-1667
Review deadline: Dec 10
Page previews
What's New in Redpanda Cloud
Shadowing in Cloud
rpk shadowin CloudChecks