Add GHSA and OSV reference type support #20710
Open
+137
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocapikk
force-pushed
the
add-ghsa-reference-support
branch
4 times, most recently
from
7ad0e36 to
5bee4a1
Compare
Chocapikk
changed the title
lib/msf/core/module/module_info.rb
Outdated
| if(refs and not refs.empty?) | ||
| refs.each_index do |i| | ||
| if !(refs[i].respond_to?('[]') and refs[i].length == 2) | ||
| if !(refs[i].respond_to?('[]') and (refs[i].length == 2 || refs[i].length == 3)) |
Contributor
There was a problem hiding this comment.
Would it be possible to check if GHSA present then only check for three in that particular scenario?
Contributor
Author
There was a problem hiding this comment.
Fixed in commit 990ed30. We added a ReferencesWithOptionalThirdElement constant to define which reference types can have 2 or 3 elements, and updated the validation logic to check if a reference type is in this list before allowing 3 elements. This makes the code extensible for future reference types that may need an optional third element.
The validation now only checks for 3 elements when the reference type is GHSA (or other types added to the constant), as shown in lines 81-83:
ref_type = refs[i][0]
can_have_third_element = ReferencesWithOptionalThirdElement.include?(ref_type)
valid_length = can_have_third_element ? (refs[i].length == 2 || refs[i].length == 3) : (refs[i].length == 2)
Chocapikk
force-pushed
the
add-ghsa-reference-support
branch
from
9f1642e to
990ed30
Compare
…1 modules with correct repo-specific URLs
…eference types (e.g., GHSA)
Chocapikk
force-pushed
the
add-ghsa-reference-support
branch
from
990ed30 to
f677696
Compare
…ach_index + delete)
… kind_of?, early returns, Array() helper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for GHSA (GitHub Security Advisory) and OSV (Open Source Vulnerabilities) references in Metasploit modules. Modules can now use structured reference formats instead of full URLs.
GHSA Support
The format depends on whether the GHSA is available globally or repository-specific:
['GHSA', 'xxxx-xxxx-xxxx']=>https://github.com/advisories/GHSA-xxxx-xxxx-xxxx['GHSA', 'xxxx-xxxx-xxxx', 'owner/repo']=>https://github.com/owner/repo/security/advisories/GHSA-xxxx-xxxx-xxxxOSV Support
OSV (Open Source Vulnerabilities) is a modern vulnerability database created by Google that aggregates 15+ sources and covers 25+ ecosystems (Go, Python, npm, Maven, RubyGems, GitHub advisories, and more). It provides a unified format for open source vulnerabilities.
['OSV', 'ECOSYSTEM-YEAR-ID']=>https://osv.dev/vulnerability/ECOSYSTEM-YEAR-ID['OSV', 'GO-2021-0113'],['OSV', 'PYSEC-2024-123'],['OSV', 'GHSA-8c52-x9w7-vc95']This PR also:
TypeError