Skip to content

Added Khadija to SFDC Stop Contributors #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Khadija to SFDC Stop Contributors #77

wants to merge 2 commits into from

Conversation

Khadija-P
Copy link

My First pull request

@rahulmalhotra
Copy link
Owner

Hi @Khadija-P your PR looks good, only a small change is needed. If you see here, the .sf folder is committed as well which is not required. You can follow the following steps to fix it:

  1. Delete .sf folder and commit
  2. [Optional] Add .sf folder to .gitignore file and commit again (this will ensure nobody will face the same issue as you in future)
  3. Push the commit(s) to update your PR.

The 1st and 3rd steps are also followed in this PR you can check this out for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Khadija-P @rahulmalhotra