-
-
Notifications
You must be signed in to change notification settings - Fork 95
Automated Resyntax fixes #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
4d7c9a3
5e1f4b7
b62a4cc
0a97274
2ab4a07
18d3b59
e87e4f9
c27c4ab
d8ee5ff
1fed9f7
ded4cf5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,13 +139,11 @@ This test checks: | |
| (process-container item))))) | ||
|
|
||
| (define (record-shortcut item) | ||
| (when (is-a? item selectable-menu-item<%>) | ||
| (when (send item get-shortcut) | ||
| (define k (append (sort (send item get-shortcut-prefix) | ||
| string<=? | ||
| #:key symbol->string) | ||
| (list (send item get-shortcut)))) | ||
| (hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '())))) | ||
| (when (and (is-a? item selectable-menu-item<%>) (send item get-shortcut)) | ||
| (define k | ||
| (append (sort (send item get-shortcut-prefix) string<=? #:key symbol->string) | ||
| (list (send item get-shortcut)))) | ||
| (hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '()))) | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not digging this change; the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The line breaks are There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've filed jackfirth/resyntax#639 to address this. |
||
| (define (get-lab item) | ||
| (cond | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see that you have already done something about this, @jackfirth . But also, this isn't a problem with the arguments of the function.