Skip to content

Conversation

@danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Nov 4, 2025

Stacked PRs:


[mxfp8 moe training] update benchmarks and tests; simplify per group blocked swizzle ref function

Changes

  • Update benchmark_2d_3d_grouped_gemm.py to use torch._scaled_grouped_mm instead of the fbgemm custom op, now that it is integrated in core
  • Simplify torch_to_blocked_2d_M_groups to not require K param as it is not needed, update tests and benchmarks accordingly
  • Update bench_triton_mx_block_rearrange_2d_M_groups.py to also bench larger, more realistic total_M dim

…blocked swizzle ref function

stack-info: PR: #3286, branch: danielvegamyhre/stack/83
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3286

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 494df3f with merge base 01374eb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

danielvegamyhre added a commit that referenced this pull request Nov 4, 2025
…blocked swizzle ref function

stack-info: PR: #3286, branch: danielvegamyhre/stack/83
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/83 branch from df83d6e to 497998a Compare November 4, 2025 00:42
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@danielvegamyhre danielvegamyhre added mx moe topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Nov 4, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/82 to main November 4, 2025 00:48
danielvegamyhre added a commit that referenced this pull request Nov 4, 2025
…blocked swizzle ref function

stack-info: PR: #3286, branch: danielvegamyhre/stack/83
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/83 branch from 497998a to 64f9440 Compare November 4, 2025 00:48
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/82 November 4, 2025 00:48
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/82 to main November 4, 2025 16:34
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/83 branch from 64f9440 to 494df3f Compare November 4, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. moe mx topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants