Update common used toy linear model #3275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jerry Zhang <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3275
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
thanks for splitting the PR, this should be much easier to land |
jerryzh168
reviewed
Nov 4, 2025
| if model_type == "linear": | ||
| model = ToyLinearModel(k, n, high_precision_dtype).to(device) | ||
| model = ToySingleLinearModel(k, n, device=device, dtype=high_precision_dtype) | ||
| input_data = torch.randn(m, k, device=device, dtype=high_precision_dtype) |
There was a problem hiding this comment.
can this be changed to use example_inputs from model now
e.g. input_data = model.example_inputs(batch_size=m)[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is smaller chunks of #2729. Instead of implementing a linear model in each test code, we want to support its API for developers' utility and consistency. The updated toy model requires device and dtype to help clearly identify.
Test Plan:
test/sparsity/test_fast_sparse_training.py
Future Plan:
This PR only updates the toy model in test/sparsity/test_fast_sparse_training.py. For a full update, we also have to update the following tests, same as
test_fast_sparse_training.py:cc @jerryzh168