Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/_fbgemm_gpu_cuda_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ jobs:
# clang-16: error: unknown argument: '-fno-tree-loop-vectorize'
run: . $PRELUDE; install_cxx_compiler $BUILD_ENV gcc

- name: Install Build Tools
run: . $PRELUDE; install_build_tools $BUILD_ENV

- name: Install CUDA
run: . $PRELUDE; install_cuda $BUILD_ENV ${{ matrix.cuda-version }}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,7 @@ def get_table_name_for_logging(table_names: Optional[list[str]]) -> str:
return "<Unknown>"
# Do this because sometimes multiple shards of the same table could appear
# in one TBE.
table_name_set = set(table_names)
table_name_set = sorted(set(table_names))
if len(table_name_set) == 1:
return next(iter(table_name_set))
return f"<{len(table_name_set)} tables>: {table_name_set}"
Expand Down
4 changes: 1 addition & 3 deletions fbgemm_gpu/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

# @licenselint-loose-mode

import argparse
import logging
import os
Expand Down Expand Up @@ -655,7 +653,7 @@ def main(argv: list[str]) -> None:
]
+ [
f"Programming Language :: Python :: {x}"
for x in ["3", "3.9", "3.10", "3.11", "3.12", "3.13"]
for x in ["3", "3.10", "3.11", "3.12", "3.13"]
],
)

Expand Down
6 changes: 3 additions & 3 deletions fbgemm_gpu/test/tbe/utils/split_embeddings_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,17 +178,17 @@ def test_get_table_name_for_logging(self) -> None:
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging(
["t1", "t2"]
),
"<2 tables>: {'t1', 't2'}",
"<2 tables>: ['t1', 't2']",
)
self.assertEqual(
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging(
["t1", "t2", "t1"]
),
"<2 tables>: {'t1', 't2'}",
"<2 tables>: ['t1', 't2']",
)
self.assertEqual(
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging([]),
"<0 tables>: set()",
"<0 tables>: []",
)

@unittest.skipIf(*gpu_unavailable)
Expand Down
Loading