Support larger lookup in permute (#2094) #5086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebookresearch/FBGEMM#2094 Differential Revision: D86209662
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Contributor
|
This pull request has been merged in 95230e2. |
Bernard-Liu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Nov 11, 2025
Summary: Pull Request resolved: pytorch#5086 X-link: https://github.com/facebookresearch/FBGEMM/pull/2094 For lengths per shard exceeding 2^31, we avoid overflow resulting in undefined behavior. Reviewed By: spcyppt Differential Revision: D86209662 fbshipit-source-id: 6d51290f3436629571677091c42b76b6f98e5790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: https://github.com/facebookresearch/FBGEMM/pull/2094
Differential Revision: D86209662