Merge pull request #493 from python-cmd2/extra_slash

Fixed case where extra slash was printing when tab completing users on Windows

Author: kmvanbrunt

CHANGELOG.md

@@ -1,4 +1,8 @@
-## 0.8.8 (TBD, 2018)
+## 0.8.9 (August TBD, 2018)
+* Bug Fixes
+    * Fixed extra slash that could print when tab completing users on Windows
+
+## 0.8.8 (June 28, 2018)
 * Bug Fixes
     * Prevent crashes that could occur attempting to open a file in non-existent directory or with very long filename
 * Enhancements

cmd2.py

@@ -229,7 +229,7 @@ def pyreadline_remove_history_item(pos):
         pass
 
 
-__version__ = '0.8.8'
+__version__ = '0.8.9'
 
 # Pyparsing enablePackrat() can greatly speed up parsing, but problems have been seen in Python 3 in the past
 pyparsing.ParserElement.enablePackrat()
@@ -1694,12 +1694,15 @@ def complete_users():
             users = []
 
             # Windows lacks the pwd module so we can't get a list of users.
-            # Instead we will add a slash once the user enters text that
+            # Instead we will return a result once the user enters text that
             # resolves to an existing home directory.
             if sys.platform.startswith('win'):
                 expanded_path = os.path.expanduser(text)
                 if os.path.isdir(expanded_path):
-                    users.append(text + os.path.sep)
+                    user = text
+                    if add_trailing_sep_if_dir:
+                        user += os.path.sep
+                    users.append(user)
             else:
                 import pwd
 

docs/conf.py

@@ -62,7 +62,7 @@
 # The short X.Y version.
 version = '0.8'
 # The full version, including alpha/beta/rc tags.
-release = '0.8.8'
+release = '0.8.9'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

setup.py

@@ -8,7 +8,7 @@
 import setuptools
 from setuptools import setup
 
-VERSION = '0.8.8'
+VERSION = '0.8.9'
 DESCRIPTION = "cmd2 - a tool for building interactive command line applications in Python"
 LONG_DESCRIPTION = """cmd2 is a tool for building interactive command line applications in Python. Its goal is to make
 it quick and easy for developers to build feature-rich and user-friendly interactive command line applications.  It

tests/test_cmd2.py

@@ -26,7 +26,7 @@
 
 
 def test_ver():
-    assert cmd2.__version__ == '0.8.8'
+    assert cmd2.__version__ == '0.8.9'
 
 
 def test_empty_statement(base_app):