Fix structured output with nested definitions with Gemini via OpenRouter #3618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion errors link to fallbackmodel in agnets.md
DouweM
requested changes
Dec 2, 2025
Collaborator
DouweM
left a comment
DouweM
left a comment
There was a problem hiding this comment.
@dsfaccini We should also have a recorded test that verifies that a nested schema now works properly with OpenRouter + Gemini again
| """ | ||
| is_image_model = 'image' in model_name | ||
| is_3_or_newer = 'gemini-3' in model_name | ||
| return GoogleModelProfile( |
Collaborator
There was a problem hiding this comment.
We shouldn't copy paste all of this! We should call the original google_model_profile, and then do the replace thing to swap out just the transformer
| ) from _import_error | ||
|
|
||
|
|
||
| class OpenRouterGoogleJsonSchemaTransformer(JsonSchemaTransformer): |
Collaborator
There was a problem hiding this comment.
This is public now, I don't think it should be :)
DouweM
changed the title
DouweM
requested changes
Dec 3, 2025
tests/providers/test_openrouter.py
Outdated
| assert result['properties']['email']['description'] == 'User email (format: email)' | ||
| assert 'format' not in result['properties']['email'] | ||
|
|
||
| # format -> description without existing description (lines 76-77) |
Collaborator
There was a problem hiding this comment.
These line numbers will get outdated; please don't include them
tests/models/test_openrouter.py
Outdated
| ToolDefinition( | ||
| name='insert_level_with_spaces', | ||
| description=InsertLevelWithSpaces.__doc__ or '', | ||
| parameters_json_schema=InsertLevelWithSpaces.model_json_schema(), |
Collaborator
There was a problem hiding this comment.
Let's use an Agent with a @agent.tool so we are sure that it goes through the exact same processing that users would see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3617 temporarily while support is added.