Skip to content

Conversation

@DenysMoskalenko
Copy link
Contributor

Summary

Implements AWS Bedrock prompt caching support (see #3418) by fixing how cache points are sent, documenting the workflow, and extending test coverage to assert cache writes and reads.

Testing

  • uv run pytest tests/models/test_bedrock.py
  • uv run coverage run -m pytest tests/models/test_bedrock.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DouweM It's mostly the duplication of the same documentation we have for Anthropic CachePoint. What do you think, maybe we need to move it somewhere?

  - Emit cache-point tool entries so Bedrock accepts cached tool definitions
  - Document and test prompt caching (writes + reads) with cassette-body checks
  - Refresh Bedrock cassettes and type annotations to align with the new flow
@DenysMoskalenko DenysMoskalenko force-pushed the feature/add_anthropick_prompt_caching_on_bedrock branch from 5263d8a to 6612939 Compare November 15, 2025 15:55
@DenysMoskalenko
Copy link
Contributor Author

@DouweM Is there any change to continue with this PR? We need this feature a lot 🙏.

I read the #3453 but I guess that we can add bedrock support in the same way and make changes later for both places if needed, instead of just ignoring the Bedrock users. What do you think?

@DouweM
Copy link
Collaborator

DouweM commented Nov 18, 2025

@DenysMoskalenko Thanks for working on this Denys!

I guess that we can add bedrock support in the same way and make changes later for both places if needed, instead of just ignoring the Bedrock users. What do you think?

Agreed. Can you please have a look at these issues and address them in case they affect this implementation as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants