-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add WebFetchTool builtin tool support #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@DouweM would you prefer if we renamed UrlContextTool to WebFetchTool and left UrlContextTool in a google-only deprecated state? |
|
|
||
| | Provider | Supported | Notes | | ||
| |----------|-----------|-------| | ||
| | Anthropic | ✅ | Full feature support. Uses Anthropic's [Web Fetch Tool](https://docs.claude.com/en/docs/agents-and-tools/tool-use/web-fetch-tool) internally to retrieve URL contents. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer your question in the comment: let's rename the entire thing to WebFetchTool, and keep UrlContextTool around only as an alias with a deprecation warning.
docs/builtin-tools.md
Outdated
|
|
||
| _(This example is complete, it can be run "as is")_ | ||
|
|
||
| With Google, you can also use `UrlContextTool`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need one example as the only difference is the model name.
Per the above, let's not mention UrlContextTool anymore.
Should we support any of the options on https://docs.claude.com/en/docs/agents-and-tools/tool-use/web-fetch-tool#tool-definition? If so, that'd warrant a new section and Anthropic-specific example. But ideally Google would also support at least some of those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I'll look into adding those options
tests/models/test_anthropic.py
Outdated
| assert len(tool_calls) >= 1 | ||
| assert len(tool_returns) >= 1 | ||
| assert any(tc.tool_name == 'url_context' for tc in tool_calls) | ||
| assert any(tr.tool_name == 'url_context' for tr in tool_returns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use full snapshots like in the other builtin tool tests
tests/models/test_anthropic.py
Outdated
| 'Pydantic AI is a Python agent framework designed to help you quickly, confidently, and painlessly build production grade applications and workflows with Generative AI.' | ||
| ) | ||
|
|
||
| messages = agent_run.result.all_messages() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above; full snapshots of messages and events please
tests/models/test_anthropic.py
Outdated
|
|
||
|
|
||
| @pytest.mark.vcr() | ||
| async def test_anthropic_url_context_tool_multi_turn(allow_model_requests: None, anthropic_api_key: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See tests for other builtin tools: we typically check this by having 2 agent.runs in the same non-streaming test, where the second takes the history of the first to ensure that the API accepts it.
tests/models/test_anthropic.py
Outdated
| assert len(anthropic_messages) == 0 # No messages should be added | ||
|
|
||
|
|
||
| @pytest.mark.vcr() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these changes necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unecessary, my bad - removed 👍
tests/models/test_anthropic.py
Outdated
| ) | ||
|
|
||
| result = await agent.run('How much is 3 * 12390?') | ||
| result = await agent.run('How much is 3 * 12390?') # pragma: lax no cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the new # pragma: lax no covers, I don't think they should be needed
Closes #2971
WebFetchToolbuiltin tool for Anthropic/Google models, which uses the (Claude WebFetch tool / Google URL Context tool) under-the-hoodUrlContextTool(which was Google-only) as users should now useWebFetchToolinsteadBetaWebFetchToolResultBlockParamContent(web fetch url / retrieved_at / source data / etc) in the Pydantic AIBuiltinToolReturnPartthat arrives in the agent message history, so that Pydantic AI users have access to the full web fetch tool return objectWebFetchToolthat get passed to the Claude WebFetch tool under-the-hood; these params are not supported by Google'sUrlContextToolDictunfortunately