Skip to content

Improve milestone retrieval #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdembowski wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve milestone retrieval #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99427cd
Improve GitHub milestone retrieval
gdembowski Nov 21, 2025
2078e29
Refactor indentation
gdembowski Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions src/githubHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,31 @@ export class GithubHelper {
*/
async getAllGithubMilestones(): Promise<SimpleMilestone[]> {
try {
await utils.sleep(this.delayInMs);
// get an array of GitHub milestones for the new repo
let result = await this.githubApi.issues.listMilestones({
owner: this.githubOwner,
repo: this.githubRepo,
state: 'all',
});
let allMilestones: SimpleMilestone[] = [];
let page = 1;
const perPage = 100;

while (true) {
await utils.sleep(this.delayInMs);
const result = await this.githubApi.issues.listMilestones({
owner: this.githubOwner,
repo: this.githubRepo,
state: 'all',
per_page: perPage,
page,
});

if (result.data.length === 0) break;

allMilestones = allMilestones.concat(
result.data.map(x => ({ number: x.number, title: x.title })),
);

if (result.data.length < perPage) break;
page++;
}

return result.data.map(x => ({ number: x.number, title: x.title }));
return allMilestones;
} catch (err) {
console.error('Could not access all GitHub milestones');
console.error(err);
Expand Down