fix: using pool_size as pg conn max_size if not set #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Copilot finished reviewing on behalf of
elvizlai
December 3, 2025 04:08
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #15 by setting a default min_size parameter for the PostgreSQL connection pool in the synchronous PGMQueue implementation. The change ensures that when min_size is not explicitly provided in the kwargs, it defaults to the value of pool_size.
Key Changes:
- Added
self.kwargs.setdefault("min_size", self.pool_size)before ConnectionPool initialization - This ensures the connection pool has a minimum size configuration when not explicitly set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elvizlai
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solving #15