[bug/qa] Fix lint errors being ignored #485

.github/workflows/ci.yml

@@ -38,6 +38,7 @@ jobs:
           python-version: "3.12"
 
       - name: Install python dependencies
+        id: deps
         run: |
           pip install -U pip wheel setuptools
           pip install -r requirements-test.txt
@@ -51,6 +52,7 @@ jobs:
           ./run-qa-checks
 
       - name: Tests
+        if: ${{ !cancelled() && steps.deps.conclusion == 'success' }}
         run: |
           mkdir -p ~/.ansible/roles
           ln -s $GITHUB_WORKSPACE ~/.ansible/roles/openwisp.openwisp2

.yamllint.yml

@@ -5,3 +5,15 @@ rules:
   line-length:
     max: 162
     level: warning
+  truthy:
+    level: warning
+ignore: |
+  .venv
+  venv
+  env
+  myenv
+  *.py
+  __pycache__
+  .tox
+  .git
+  .github

molecule/default/molecule.yml

@@ -6,10 +6,6 @@ dependency:
     role-file: molecule/resources/requirements.yml
 driver:
   name: docker
-lint: |
-  set -e
-  yamllint . || true
-  ansible-lint || true
 platforms:
   - name: "${ROLE_NAME:-instance}-${MOLECULE_DISTRO}"
     image: "geerlingguy/docker-${MOLECULE_DISTRO}-ansible:${tag:-latest}"
@@ -28,7 +24,9 @@ provisioner:
     verify: ../resources/verify.yml
   config_options:
     defaults:
-      stdout_callback: yaml
+      callbacks_enabled:
+        - ansible.builtin.default
+      result_format: yaml
       bin_ansible_callbacks: true
   inventory:
     host_vars:

molecule/local/molecule.yml

@@ -6,10 +6,6 @@ dependency:
     role-file: molecule/resources/requirements.yml
 driver:
   name: docker
-lint: |
-  set -e
-  yamllint . || true
-  ansible-lint || true
 platforms:
   - name: "openwisp2-ubuntu2404"
     image: "geerlingguy/docker-ubuntu2404-ansible:latest"
@@ -60,7 +56,9 @@ provisioner:
     verify: ../resources/verify.yml
   config_options:
     defaults:
-      stdout_callback: yaml
+      callbacks_enabled:
+        - ansible.builtin.default
+      result_format: yaml
       bin_ansible_callbacks: true
 verifier:
   name: ansible

molecule/resources/converge.yml

@@ -32,7 +32,7 @@
     - name: Install net-tools
       apt:
         name:
-        - net-tools
+          - net-tools
 
     - name: Remove the .dockerenv file
       file:

run-qa-checks

@@ -5,3 +5,7 @@ openwisp-qa-check --skip-isort \
   --skip-flake8 \
   --skip-black \
   --skip-checkmigrations
+
+# Run Ansible linting
+yamllint --strict --config-file .yamllint.yml .
+ansible-lint

vars/debian-13.yml

@@ -1,6 +1,6 @@
 ---
 
-# Override variables for Debian 13 
+# Override variables for Debian 13
 
 openwisp2_ntp_pkg: ntpsec
 openwisp2_libgdk_pixbuf_pkg: libgdk-pixbuf-2.0-0