Skip to content

Fix for Sound error - #3 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for Sound error - #3 #7

wants to merge 3 commits into from

Conversation

@ewels
Copy link
Member

@ewels ewels commented Nov 26, 2025

Optionally disable sound for folks on systems where there is no midi controller. Best we can do without upstream fixes.

@claude
Fix NullPointerException when MIDI devices unavailable
2dfe6c2 
Add -nomusic flag to MochaDoom to prevent crash when running on
systems without MIDI devices. The error occurred in
DavidMusicModule.sendSysexMessage() when VolumeScalingReceiver
returns null due to unavailable MIDI hardware.

Fixes #3
@claude
Add --nomusic parameter for systems without MIDI devices
838c66a 
Instead of hardcoding -nomusic flag, add a params.nomusic option
that users can enable when running on systems without MIDI audio
hardware.

Also add troubleshooting section to README documenting the
NullPointerException error and the workaround.

Fixes #3
@ewels ewels linked an issue Nov 26, 2025 that may be closed by this pull request
Sound error #3
Open
@ewels
Copy link
Member Author

ewels commented Nov 27, 2025

Tested it - it does indeed turn off the music, but there is still sound effects.

@nvnieuwk @jfy133 does this fix the issue for you?

Testing command:

nextflow run doom -r claude/investigate-issue-3-01VTdDE4CVdvHKGLQ47LZECd --nomusic

@jfy133
Copy link

jfy133 commented Nov 27, 2025

Yeah the game loads now but somehow the sound comes through my laptop speakers and ignores any form of volume control or muting 🙃

@nvnieuwk
Copy link

nvnieuwk commented Nov 27, 2025

It doesn't open a pop up with the game for me :/

@nvnieuwk
Copy link

nvnieuwk commented Nov 27, 2025 

$ nextflow run doom -r main -latest --nomusic

 N E X T F L O W   ~  version 25.10.0

Pulling nextflow-io/doom ...
 Already-up-to-date
Launching `https://github.com/nextflow-io/doom` [thirsty_goodall] DSL2 - revision: c45e0a1213 [main]

executor >  local (3)
[40/a9966f] process > printLogo  [100%] 1 of 1 ✔
[a6/05d0ac] process > printQuote [100%] 1 of 1 ✔
[18/cc3c0a] process > playDoom   [  0%] 0 of 1
[-        ] process > insultUser -

▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒
▒▒████████████████████▒▒██████████████████▒▒██████████████████▒▒██████▒▒▒▒▒▒████████▒▒
▒▒▒▒██████████████████▒▒██████████████████▒▒██████████████████▒▒██████▒▒▒▒▒▒██████▒▒▒▒
  ▒▒██████████████████▒▒██████████████████▒▒██████████████████▒▒████████▒▒████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████████████████▒▒
  ▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒▒▒▒▒██████▒▒██████▒▒██▒▒██████▒▒
  ▒▒██████▒▒▒▒████████▒▒████████▒▒▒▒██████▒▒██████▒▒▒▒████████▒▒██████▒▒▒▒▒▒██████▒▒
  ▒▒██████▒▒████████▒▒▒▒▒▒████████████████▒▒████████████████▒▒▒▒▒▒████▒▒  ▒▒██████▒▒
  ▒▒██████████████▒▒▒▒  ▒▒▒▒████████████▒▒▒▒▒▒████████████▒▒▒▒  ▒▒████▒▒  ▒▒██████▒▒
  ▒▒████████████▒▒▒▒      ▒▒▒▒████████▒▒▒▒  ▒▒▒▒████████▒▒▒▒    ▒▒▒▒██▒▒  ▒▒██████▒▒
  ▒▒██████████▒▒▒▒          ▒▒▒▒████▒▒▒▒      ▒▒▒▒████▒▒▒▒        ▒▒▒▒▒▒  ▒▒██████▒▒
  ▒▒████████▒▒▒▒              ▒▒▒▒▒▒▒▒          ▒▒▒▒▒▒▒▒                  ▒▒▒▒████▒▒
  ▒▒██████▒▒▒▒                                                              ▒▒████▒▒
  ▒▒████▒▒▒▒                                                                ▒▒▒▒██▒▒
  ▒▒██▒▒▒▒                                                                    ▒▒██▒▒
  ▒▒▒▒▒▒                                                                      ▒▒▒▒▒▒


        ══════════════════════════════════════════════════════════════════════
          They are rage, brutal, without mercy. But you... you will be worse.
        ══════════════════════════════════════════════════════════════════════

@claude
Add --nosound parameter to disable all audio
595bac3 
Add params.nosound option that disables all sound (music and effects).
The --nosound flag takes precedence over --nomusic.

Updated README to document both options.
@ewels
Copy link
Member Author

ewels commented Nov 27, 2025 •
edited
Loading

@jfy133 I've added a --nosound to completely disable all sound. Is that better?

@nvnieuwk - That's how the log output is meant to look now, but yeah - a game should still load.. Anything in .nextflow.log or the task's work dir?

@nvnieuwk
Copy link

nvnieuwk commented Nov 28, 2025

I used the wrong revision 🤦 All fine!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sound error

5 participants

@ewels @jfy133 @nvnieuwk @claude