Correct ejection side for param2=1&3 #417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machines should always eject to their right. Prior to this patch that was incorrect depending on the rotation of the machine
Contributor
|
This will break a lot of existing setups, and we can't do that. This bug has existed forever, and there isn't a simple fix that won't break stuff. I suggested a fix for it in #337, but no one has got around to implementing it yet. |
Contributor
We may work around that by using an LBM to turn things around, or a tracking bit in metadata. Both are not the most elegant solution, but keeps old machine working while fixing this bug for newly placed down nodes / new servers. |
|
i agree with the metadata bit. death by settings seems terrible, should be straight forward and logical for users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Machines should always eject to their right, regardless of rotation.
Prior to this patch that was incorrect depending on the rotation of the machine, with param2 == 1 or 3 machines ejecting to the left.
This may break existing setups that have already accounted for this quirk, but IMO it's better to be consistent.
May or may not have been relevant: #336