Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/mcp/server/elicitation.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from __future__ import annotations

import types
from enum import Enum
from typing import Generic, Literal, TypeVar, Union, get_args, get_origin

from pydantic import BaseModel
Expand Down Expand Up @@ -37,7 +38,7 @@ class CancelledElicitation(BaseModel):


# Primitive types allowed in elicitation schemas
_ELICITATION_PRIMITIVE_TYPES = (str, int, float, bool)
_ELICITATION_PRIMITIVE_TYPES = (str, int, float, bool, Enum)


def _validate_elicitation_schema(schema: type[BaseModel]) -> None:
Expand Down Expand Up @@ -70,6 +71,10 @@ def _is_primitive_field(field_info: FieldInfo) -> bool:
# All args must be primitive types or None
return all(arg is types.NoneType or arg in _ELICITATION_PRIMITIVE_TYPES for arg in args)

# Handle Enum types
if isinstance(annotation, type) and issubclass(annotation, str) and issubclass(annotation, Enum):
return True

return False


Expand Down
34 changes: 34 additions & 0 deletions tests/server/fastmcp/test_elicitation.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Test the elicitation feature using stdio transport.
"""

from enum import Enum
from typing import Any

import pytest
Expand Down Expand Up @@ -142,6 +143,39 @@ async def elicitation_callback(context: RequestContext[ClientSession, None], par
assert "Validation failed as expected" in result.content[0].text
assert field_name in result.content[0].text

# Test valid Enum types (should not fail validation)
class Status(str, Enum):
ACTIVE = "active"
INACTIVE = "inactive"

class ValidStrEnumSchema(BaseModel):
status: Status = Field(description="Status using StrEnum")

def create_valid_validation_tool(name: str, schema_class: type[BaseModel]):
@mcp.tool(name=name, description=f"Tool testing {name}")
async def tool(ctx: Context[ServerSession, None]) -> str:
# This should succeed without validation error
result = await ctx.elicit(message="Test valid schema", schema=schema_class)
return f"Success: {result.action}"

return tool

create_valid_validation_tool("valid_strenum", ValidStrEnumSchema)

async def enum_callback(context: RequestContext[ClientSession, None], params: ElicitRequestParams):
# Return the required status field
return ElicitResult(action="accept", content={"status": "active"})

async with create_connected_server_and_client_session(
mcp._mcp_server, elicitation_callback=enum_callback
) as client_session:
await client_session.initialize()

result = await client_session.call_tool("valid_strenum", {})
assert len(result.content) == 1
assert isinstance(result.content[0], TextContent)
assert "Success: accept" == result.content[0].text


@pytest.mark.anyio
async def test_elicitation_with_optional_fields():
Expand Down