Skip to content

Make test dependencies required instead of optional #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Draft

Make test dependencies required instead of optional #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
enable-cache: true
version: 0.9.5
- name: Install dependencies
run: uv sync --frozen --all-extras --python 3.10
run: uv sync --frozen --python 3.10

- uses: pre-commit/[email protected]
with:
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
version: 0.9.5

- name: Install the project
run: uv sync ${{ matrix.dep-resolution.install-flags }} --all-extras --python ${{ matrix.python-version }}
run: uv sync ${{ matrix.dep-resolution.install-flags }} --python ${{ matrix.python-version }}

- name: Run pytest
run: uv run ${{ matrix.dep-resolution.install-flags }} --no-sync pytest
Expand All @@ -71,7 +71,7 @@ jobs:
version: 0.9.5

- name: Install dependencies
run: uv sync --frozen --all-extras --python 3.10
run: uv sync --frozen --python 3.10

- name: Check README snippets are up to date
run: uv run --frozen scripts/update_readme_snippets.py --check
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ dev = [
"pytest-pretty>=1.2.0",
"inline-snapshot>=0.23.0",
"dirty-equals>=0.9.0",
# Optional dependencies needed for testing
"rich>=13.9.4",
"typer>=0.16.0",
"python-dotenv>=1.0.0",
"websockets>=15.0.1",
Comment on lines +63 to +67
Copy link
Member

@Kludex Kludex Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as: https://github.com/Kludex/starlette/pull/2999/files#r2327181201

Suggested change
# Optional dependencies needed for testing
"rich>=13.9.4",
"typer>=0.16.0",
"python-dotenv>=1.0.0",
"websockets>=15.0.1",
# Optional dependencies needed for testing
"mcp[rich, cli, ws]"

]
docs = [
"mkdocs>=1.6.1",
Expand Down
8 changes: 8 additions & 0 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.