[Server] Decouple Protocol from TransportInterface for reusability #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvluoyue
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
lvluoyue
force-pushed
the
main
branch
4 times, most recently
from
67940d9 to
334e206
Compare
lvluoyue
changed the title
9 tasks
Member
|
Makes sense to me - @CodeWithKyrian agree? see related symfony/ai#999 for motivation |
Contributor
|
Makes perfect sense to me as well 👍🏼👍🏼. |
chr-hertel
approved these changes
Nov 29, 2025
Nyholm
approved these changes
Nov 30, 2025
Contributor
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Lovely. I agree to make the Protocol stateless
Member
|
missed to put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple the Protocol class from direct dependency on TransportInterface to support server instance reuse across multiple transport mechanisms.
Motivation and Context
Currently, the Protocol class can only be connected to a single transport instance due to internal state management and restrictions. Once connected, it cannot be reused with another transport. This change removes that limitation to allow a single Protocol instance to be used with multiple transports.The same issue exists in the TypeScript SDK: modelcontextprotocol/typescript-sdk#961
Types of changes
Checklist