-
Notifications
You must be signed in to change notification settings - Fork 39
docs: migrated the Reports component from the old docs to the new docs #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Changes from 2 commits
6eaa9a3
676a03f
e6ef5b6
19662e0
daa5b73
fe1e57c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,220 @@ | ||||||
| Reports | ||||||
| ####### | ||||||
| To add and render custom reports in Mautic, your plugin needs to listen to three events: | ||||||
|
Check warning on line 3 in docs/components/reports.rst
|
||||||
|
|
||||||
| - ``\Mautic\ReportBundle\ReportEvents::REPORT_ON_BUILD`` | ||||||
| - ``ReportEvents::REPORT_ON_GENERATE`` | ||||||
| - ``ReportEvents::REPORT_ON_GRAPH_GENERATE`` | ||||||
|
|
||||||
| This guide walks you through defining a custom report, generating report data, and rendering graphs. | ||||||
|
Check warning on line 9 in docs/components/reports.rst
|
||||||
|
||||||
| This guide walks you through defining a custom report, generating report data, and rendering graphs. | |
| This guide walks you through defining a custom Report, generating Report data, and rendering graphs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, I have fixed this
Check warning on line 11 in docs/components/reports.rst
GitHub Actions / prose
[vale] reported by reviewdog 🐶
[Google.Headings] 'Defining the Report' should use sentence-style capitalization.
Raw Output:
{"message": "[Google.Headings] 'Defining the Report' should use sentence-style capitalization.", "location": {"path": "docs/components/reports.rst", "range": {"start": {"line": 11, "column": 1}}}, "severity": "WARNING"}
OfficialJhimmy marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix your headings throughout the whole doc.
H1 ###
H2 ***
H3 ===
H4 ---
H5 ~~~
H6 ^^^
Check warning on line 16 in docs/components/reports.rst
GitHub Actions / prose
[vale] reported by reviewdog 🐶
[Mautic.FeatureList] Is this referring to a Mautic feature? If so, use 'Report' instead of 'report'.
Raw Output:
{"message": "[Mautic.FeatureList] Is this referring to a Mautic feature? If so, use 'Report' instead of 'report'.", "location": {"path": "docs/components/reports.rst", "range": {"start": {"line": 16, "column": 7}}}, "severity": "INFO"}
OfficialJhimmy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Check warning on line 18 in docs/components/reports.rst
GitHub Actions / prose
[vale] reported by reviewdog 🐶
[Google.Parens] Use parentheses judiciously.
Raw Output:
{"message": "[Google.Parens] Use parentheses judiciously.", "location": {"path": "docs/components/reports.rst", "range": {"start": {"line": 18, "column": 21}}}, "severity": "INFO"}
OfficialJhimmy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Check warning on line 21 in docs/components/reports.rst
GitHub Actions / prose
[vale] reported by reviewdog 🐶
[Google.Headings] 'Column Definition' should use sentence-style capitalization.
Raw Output:
{"message": "[Google.Headings] 'Column Definition' should use sentence-style capitalization.", "location": {"path": "docs/components/reports.rst", "range": {"start": {"line": 21, "column": 1}}}, "severity": "WARNING"}
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Column Definition | |
| Column definition |
Check failure on line 46 in docs/components/reports.rst
GitHub Actions / prose
[vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'conjuction'?
Raw Output:
{"message": "[Vale.Spelling] Did you really mean 'conjuction'?", "location": {"path": "docs/components/reports.rst", "range": {"start": {"line": 46, "column": 52}}}, "severity": "ERROR"}
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - An alias for the returned value. Useful in conjuction with ``formula``. | |
| - An alias for the returned value. Useful in conjunction with ``formula``. |
Vale picked up the typo - @OfficialJhimmy please use Vale within your editor to save reviewers having to snag these issues. Shout if you need help with setting that up, VSCode should work out of the box with Vale.
Check failure on line 50 in docs/components/reports.rst
GitHub Actions / prose
[vale] reported by reviewdog 🐶
[Google.Latin] Use 'for example' instead of 'e.g.'.
Raw Output:
{"message": "[Google.Latin] Use 'for example' instead of 'e.g.'.", "location": {"path": "docs/components/reports.rst", "range": {"start": {"line": 50, "column": 42}}}, "severity": "ERROR"}
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - SQL formula instead of a column. e.g. ``SUBSTRING_INDEX(e.type, \'.\', 1)``. | |
| - SQL formula instead of a column, for example ``SUBSTRING_INDEX(e.type, \'.\', 1)``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not use vale off. This has hidden some problems with the grammar. Remove them everywhere except where I've suggested to use, and we'll tell you where you can use them if needed.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need reformatting into active voice. The vale off has hidden the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I have fixed this.