Follow-up to #583: Modernize remaining manifests updating ReplicationController to Deployment #586
+51
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/assign idvoretskyi |
janetkuo
reviewed
Nov 18, 2025
Member
janetkuo
left a comment
janetkuo
left a comment
There was a problem hiding this comment.
Thanks for the fix! Would you update the README as well?
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sorcerer-ares The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-rebase
…icationController with Deployment
sorcerer-ares
force-pushed
the
updating-rc-to-deployment
branch
from
cbdbf60 to
72c1752
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/M
soltysh
suggested changes
Nov 20, 2025
web/guestbook-go/README.md
Outdated
| This example shows how to build a simple multi-tier web application using Kubernetes and Docker. The application consists of a web front end, Redis master for storage, and replicated set of Redis replicas, all for which we will create Kubernetes replication controllers, pods, and services. | ||
| This example shows how to build a simple multi-tier web application using Kubernetes and Docker. The application consists of a web front end, Redis master for storage, and replicated set of Redis replicas, all for which we will create Kubernetes deployments, pods, and services. | ||
|
|
||
| If you are running a cluster in Google Container Engine (GKE), instead see the [Guestbook Example for Google Container Engine](https://cloud.google.com/container-engine/docs/tutorials/guestbook). |
Contributor
There was a problem hiding this comment.
Let's drop this paragraph, I believe we should ensure our docs are vendor neutral as much as possible.
web/guestbook-go/README.md
Outdated
| ### Step One: Create the Redis master pod<a id="step-one"></a> | ||
|
|
||
| Use the `examples/guestbook-go/redis-master-controller.yaml` file to create a [replication controller](https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/) and Redis master [pod](https://kubernetes.io/docs/concepts/workloads/pods/pod-overview/). The pod runs a Redis key-value server in a container. Using a replication controller is the preferred way to launch long-running pods, even for 1 replica, so that the pod benefits from the self-healing mechanism in Kubernetes (keeps the pods alive). | ||
| Use the `examples/guestbook-go/redis-master-controller.yaml` file to create a [Deployment](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/) and Redis master [pod](https://kubernetes.io/docs/concepts/workloads/pods/pod-overview/). The pod runs a Redis key-value server in a container. Using a deployment is the preferred way to launch long-running pods, even for 1 replica, so that the pod benefits from the self-healing mechanism in Kubernetes (keeps the pods alive). |
Contributor
There was a problem hiding this comment.
Let's add https://kubernetes.io/docs/concepts/architecture/self-healing/ link under the self-healing wording.
web/guestbook-go/README.md
Outdated
|
|
||
| ```console | ||
| $ kubectl create -f guestbook-go/redis-master-controller.yaml | ||
| $ kubectl apply -f guestbook-go/redis-master-controller.yaml |
Contributor
There was a problem hiding this comment.
Let's try to unify the approach here, currently you're using 3 different paths when pointing to this file:
- First instance uses full path
examples/guestbook-go/redis-master-controller.yaml - Second one (above) uses just
redis-master-controller.yaml - Here, you're using
guestbook-go/redis-master-controller.yaml
I'm inclined to say to stick with this file context, so just use redis-master-controller.yaml
Let's use one consistently across all, so there is no confusion to the reader.
Co-authored-by: Maciej Szulik <[email protected]>
Co-authored-by: Maciej Szulik <[email protected]>
Co-authored-by: Maciej Szulik <[email protected]>
k8s-ci-robot
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the modernization work started in #583 by updating the remaining Redis example manifests that are still using 'ReplicationController' in order to be up-to-date and maintain consistency. Deployment provides better rollout behavior, scaling, and self-healing.
Changes made:
Follow-up to: #583