-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Making CapacityBuffer ProvisioningStrategy a string (not enum) #8832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making CapacityBuffer ProvisioningStrategy a string (not enum) #8832
Conversation
|
Hi @jakubin. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can you briefly describe how this was tested?
I'd say this is a user visible change - custom provisioning strategies are now allowed. Otherwise LGTM |
|
/ok-to-test |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/release-note-edit |
It was tested on GKE Cluster Autoscaler. CA reacted properly to a capacity buffer with an unsupported provisioning strategy - ignored it and didn't process. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakubin, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
Different providers can have their own custom provisioning strategies. This field cannot be constrained by known in advance enum values.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
CapacityBuffer ProvisioningStrategy is now a free string (not enum)
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE