Skip to content

Conversation

@jakubin
Copy link
Contributor

@jakubin jakubin commented Nov 20, 2025

What type of PR is this?

/kind bug
/kind api-change

What this PR does / why we need it:

Different providers can have their own custom provisioning strategies. This field cannot be constrained by known in advance enum values.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CapacityBuffer ProvisioningStrategy is now a free string (not enum)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Make CapacityBuffer ProvisioningStrategy a string

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/needs-area labels Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jakubin. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area labels Nov 20, 2025
@aleksandra-malinowska
Copy link
Contributor

aleksandra-malinowska commented Nov 20, 2025

Can you briefly describe how this was tested?

Does this PR introduce a user-facing change?
NONE (only less validation on the field)

I'd say this is a user visible change - custom provisioning strategies are now allowed.

Otherwise LGTM

@aleksandra-malinowska
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2025
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@jackfrancis
Copy link
Contributor

/release-note-edit

Make CapacityBuffer ProvisioningStrategy a string

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 20, 2025
@jakubin jakubin marked this pull request as draft November 21, 2025 08:56
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2025
@jakubin jakubin marked this pull request as ready for review December 4, 2025 12:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2025
@jakubin
Copy link
Contributor Author

jakubin commented Dec 4, 2025

Can you briefly describe how this was tested?

It was tested on GKE Cluster Autoscaler. CA reacted properly to a capacity buffer with an unsupported provisioning strategy - ignored it and didn't process.

@x13n
Copy link
Member

x13n commented Dec 4, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakubin, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5939637 into kubernetes:master Dec 4, 2025
8 checks passed
@jakubin jakubin deleted the ProvisioningStrategyString branch December 5, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants