Skip to content

Lab2 responsive layout #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lab2 responsive layout #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Ironhack News</title>
<!--Linked to stylesheet lives in/styles/styles.css -->
<link rel="stylesheet" href="styles/style.css" />
</head>
<body>
<header>
<h1 class="newspaper-name">Ironhack News</h1>
<!-- NAV: class .navbar is used by the CSS across breakpoint -->
<nav>
<ul class="navbar">
<li><a href="#">Home</a></li>
Expand All @@ -20,9 +22,10 @@ <h1 class="newspaper-name">Ironhack News</h1>
</header>

<main>
<!-- Main 'hero' article: image + tex side by side on desktop/tablet -->
<article class="main-article">
<div class="image">
<img src="/images/main-article.jpg" alt="Article 1 Image" />
<img src="images/main-article.jpg" alt="Article 1 Image" />
</div>
<div class="content">
<h2>Main Article</h2>
Expand All @@ -37,7 +40,7 @@ <h2>Main Article</h2>
<button class="btn btn-blue">Read more</button>
</div>
</article>

<!-- Card list -->
<section class="articles-container">
<article class="article">
<img src="images/article-1.jpg" alt="Article 1 Image" />
Expand Down
91 changes: 85 additions & 6 deletions styles/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ body {

/* Basic styles */
main {
max-width: 1000px;
max-width: 1000px; /* marches the labs's desktop wigth */
margin: 0 auto;
padding: 10px 20px;
display: flex;
flex-direction: column;
flex-direction: column; /* stack sections vertically */
align-items: center;
}

Expand Down Expand Up @@ -75,12 +75,12 @@ header {
padding: 10px;
border-bottom: 1px solid white;
}

/* Navbar baseline for dedktop. We'll override in media queries*/
.navbar {
list-style-type: none;
width: 100%;
display: flex;
justify-content: flex-start;
justify-content: flex-start; /* Align items to the left */
}

.navbar li {
Expand All @@ -89,7 +89,7 @@ header {
display: flex;
align-items: center;
justify-content: center;
border-right: 1px solid #ffffff;
border-right: 1px solid #ffffff; /* Separator between items */
}

.navbar li:last-child {
Expand All @@ -107,7 +107,7 @@ header {
margin: 20px;
padding: 20px;
border: 1px solid #ccc;
display: flex;
display: flex; /* Side by side layout */
}

.main-article img {
Expand Down Expand Up @@ -177,3 +177,82 @@ header {
}

/* Write your CSS below */
/*FIXES are comented*/
/* MOBILE GOAL: stack vertically and make each item full width */
@media screen and (max-width: 760px) {
/* Navbar stacked vertically and make each item full width */
.navbar {
display: flex;
flex-direction: column; /* FIX stack items vertically */
align-items: center;
border: 3px solid white;
}
.navbar li {
width: 100%; /* FIX make each item full width */
border-right: none; /* FIX remove right border */
border-bottom: 1px solid white;
}
/* Main article: image above text */
.main-article {
flex-direction: column;
align-items: center;
}
.main-article .image,
.main-article .content {
width: 100%;
padding: 10px 0;
}
/*CARDS: 1 column*/
.articles-container {
flex-direction: column;
align-items: center
}
.article {
width: 90%; /* each article takes full width */
margin-bottom: 20px; /* space between articles */
}
/*Always keep images fluid*/
img {
max-width: 100%;
height: auto;
display: block;
}
/* TABLET (761px to 1024px)
GOAL: main article side by side, cards 2 per row
IMPORTANT: media query syntax (must use AND between min-width and max-width)
*/
@media screen and (min-width: 761px) and (max-width: 1024px) { /* ← this { fixes the error */

/* NAV: centered row with some spacing */
.navbar {
justify-content: space-around;
}

/* Main article stays side by side */
.main-article {
flex-direction: row;
}

.main-article .image,
.main-article .content {
width: 50%;
}

/* Articles: 2 columns */
.articles-container {
display: flex;
flex-wrap: wrap;
justify-content: space-between;
}

.article {
width: 45%;
}

img {
max-width: 100%;
height: auto;
display: block;
}
}
}