feat: custom dask workflow #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-held
force-pushed
the
pfackeldey/custom_dask_reduce
branch
from
f6b6c23 to
92aee7b
Compare
alexander-held
force-pushed
the
pfackeldey/custom_dask_reduce
branch
from
92aee7b to
2329e45
Compare
alexander-held
added a commit
that referenced
this pull request
Dec 4, 2025
Member
|
I opened #33 as an example using this. So far things look stable! In order to replace the custom processing code in the ATLAS setup, I think it would be great to extend the metadata and kwargs slightly. I have not yet tried purposefully crashing tasks to more closely investigate re-launching failed ones, but curious to try this out as well. |
alexander-held
approved these changes
Dec 5, 2025
Member
alexander-held
left a comment
alexander-held
left a comment
There was a problem hiding this comment.
Works great! All good to be merged from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexander-held & @MoAly98, this PR adds the new dask scheduling logic directly to the integration challenge without interfacing with the
Runner/Executorsystem of coffea. This should allow us to test it much faster.I've implemented a
DynamicAsCompletediterator, which we could also use for a pure futures executor (no dask).