Fix a bug where compile_config gets deleted #42474
Open
+16
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
to_dictmethod ofGenerationConfigalways deletes thecompile_configattribute. This is because when we callsave_pretrainedon aGenerationConfigobject, we don't want to save theCompileConfigobject.But this create an issue where
compile_configis deleted even when we load the model. For instance, this snippet:Running on
mainproduces:Running after this PR:
Thus we get the desired behavior of not saving the
compile_configwithout deleting it as soon as we load the model.